Paths

Table of Contentst

Bug XXYYZZ - Really bad patch to trigger lots of issues, r=marco
Needs ReviewPublic
Actions

Authored by • Bastien on Mar 26 2020, 10:59 AM.

Details

Reviewers

• BastienAbadie
ReviewBot
code-review-bot

Bugzilla Bug ID

Not provided

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Branch

default

Lint

No Lint Coverage

Severity	Location	Code	Message
Error	accessible/xul/XULAlertAccessible.cpp:36	RW.CLANG.ERR_INIT_CONVERSION_FAILED	Build Error
Error	toolkit/components/normandy/lib/ActionsManager.jsm:58	no-undef	eslint (Mozlint)
Error	toolkit/components/normandy/lib/ActionsManager.jsm:58	prettier/prettier	eslint (Mozlint)
Error	toolkit/locales/en-US/toolkit/global/processTypes.ftl:1	source-test-mozlint-license	license (Mozlint)
Warning	accessible/xul/XULAlertAccessible.cpp:36	invalid-styling	clang-format
Warning	dom/canvas/ClientWebGLContext.cpp:118	invalid-styling	clang-format
Warning	dom/canvas/ClientWebGLContext.cpp:118	readability-else-after-return	clang-tidy
Warning	gfx/2d/Factory.cpp:616	invalid-styling	clang-format
Warning	js/src/jit/WarpOracle.cpp:1	no-coverage	code coverage analysis

Unit

No Test Coverage

Event Timeline

• Bastien created this revision.Mar 26 2020, 10:59 AM

Herald added a project: Restricted Project. · View Herald TranscriptMar 26 2020, 10:59 AM

Harbormaster completed remote builds in B2493: Diff 2934.Mar 26 2020, 10:59 AM

• Bastien removed a project: Restricted Project.Mar 26 2020, 11:00 AM

• Bastien requested review of this revision.Mar 26 2020, 11:42 AM

• Bastien added a reviewer: • BastienAbadie.

• Bastien added reviewers: ReviewBot, code-review-bot.

Code analysis found 12 defects in the diff 2934:

8 defects found by clang-format
1 defect found by clang-tidy
2 defects found by eslint (Mozlint)
1 defect found by license (Mozlint)

You can run this analysis locally with:

./mach clang-format -s -p gfx/2d/Factory.cpp accessible/xul/XULAlertAccessible.cpp dom/canvas/ClientWebGLContext.cpp (C/C++)
./mach static-analysis check dom/canvas/ClientWebGLContext.cpp (C/C++)
./mach lint --warnings --outgoing
./mach lint --warnings --outgoing

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Code analysis found 13 defects in the diff 2934:

1 defect found by clang-tidy
1 defect found by code coverage analysis
1 defect found by license (Mozlint)
2 defects found by eslint (Mozlint)
8 defects found by clang-format

You can run this analysis locally with:

./mach clang-format -s -p accessible/xul/XULAlertAccessible.cpp dom/canvas/ClientWebGLContext.cpp gfx/2d/Factory.cpp (C/C++)
./mach lint --warnings --outgoing
./mach static-analysis check dom/canvas/ClientWebGLContext.cpp (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code ?

You can file a bug blocking Bug 1415824 for untested files that should be tested.
You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Code analysis found 8 defects in the diff 2934:

1 defect found by clang-tidy
1 defect found by code coverage analysis
1 defect found by license (Mozlint)
2 defects found by eslint (Mozlint)
3 defects found by clang-format

You can run this analysis locally with:

./mach clang-format -s -p dom/canvas/ClientWebGLContext.cpp accessible/xul/XULAlertAccessible.cpp gfx/2d/Factory.cpp (C/C++)
./mach lint --warnings --outgoing
./mach static-analysis check dom/canvas/ClientWebGLContext.cpp (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code ?

You can file a bug blocking Bug 1415824 for untested files that should be tested.
You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Mar 26 2020, 10:54 PM

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

Herald added a subscriber: phabqareview. · View Herald TranscriptMar 26 2020, 10:54 PM

Code analysis found 9 defects in the diff 2934:

1 defect found by Coverity
1 defect found by clang-tidy
1 defect found by code coverage analysis
1 defect found by license (Mozlint)
2 defects found by eslint (Mozlint)
3 defects found by clang-format

IMPORTANT: 1 build error detected.

You can run this analysis locally with:

./mach clang-format -s -p gfx/2d/Factory.cpp accessible/xul/XULAlertAccessible.cpp dom/canvas/ClientWebGLContext.cpp (C/C++)
./mach lint --warnings --outgoing
./mach static-analysis check dom/canvas/ClientWebGLContext.cpp (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code ?

You can file a bug blocking Bug 1415824 for untested files that should be tested.
You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Code analysis found 9 defects in the diff 2934:

1 defect found by Coverity
1 defect found by clang-tidy
1 defect found by code coverage analysis
1 defect found by license (Mozlint)
2 defects found by eslint (Mozlint)
3 defects found by clang-format

IMPORTANT: 1 build error detected.

You can run this analysis locally with:

./mach clang-format -s -p accessible/xul/XULAlertAccessible.cpp gfx/2d/Factory.cpp dom/canvas/ClientWebGLContext.cpp (C/C++)
./mach lint --warnings --outgoing
./mach static-analysis check dom/canvas/ClientWebGLContext.cpp (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code ?

You can file a bug blocking Bug 1415824 for untested files that should be tested.
You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Code analysis found 9 defects in the diff 2934:

1 build error found by Coverity
1 defect found by clang-tidy
1 defect found by code coverage analysis
1 defect found by license (Mozlint)
2 defects found by eslint (Mozlint)
3 defects found by clang-format

You can run this analysis locally with:

./mach clang-format -s -p gfx/2d/Factory.cpp accessible/xul/XULAlertAccessible.cpp dom/canvas/ClientWebGLContext.cpp (C/C++)
./mach lint --warnings --outgoing
./mach static-analysis check dom/canvas/ClientWebGLContext.cpp (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code ?

You can file a bug blocking Bug 1415824 for untested files that should be tested.
You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Code analysis found 9 defects in the diff 2934:

1 build error found by Coverity
1 defect found by clang-tidy
1 defect found by code coverage analysis
1 defect found by license (Mozlint)
2 defects found by eslint (Mozlint)
3 defects found by clang-format

You can run this analysis locally with:

./mach clang-format -s -p gfx/2d/Factory.cpp accessible/xul/XULAlertAccessible.cpp dom/canvas/ClientWebGLContext.cpp (C/C++)
./mach lint --warnings --outgoing
./mach static-analysis check dom/canvas/ClientWebGLContext.cpp (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code ?

You can file a bug blocking Bug 1415824 for untested files that should be tested.
You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Code analysis found 9 defects in the diff 2934:

1 build error found by Coverity
1 defect found by clang-tidy
1 defect found by code coverage analysis
1 defect found by license (Mozlint)
2 defects found by eslint (Mozlint)
3 defects found by clang-format

You can run this analysis locally with:

./mach clang-format -s -p accessible/xul/XULAlertAccessible.cpp gfx/2d/Factory.cpp dom/canvas/ClientWebGLContext.cpp (C/C++)
./mach lint --warnings --outgoing
./mach static-analysis check dom/canvas/ClientWebGLContext.cpp (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code ?

You can file a bug blocking Bug 1415824 for untested files that should be tested.
You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

// XXX
      for (const actionName of Object.keys(actionConstructors)) {
        capabilities.add(`action.${actionName}`);
      }

Code analysis found 9 defects in the diff 2934:

1 build error found by Coverity
1 defect found by clang-tidy
1 defect found by code coverage analysis
1 defect found by license (Mozlint)
2 defects found by eslint (Mozlint)
3 defects found by clang-format

You can run this analysis locally with:

./mach clang-format -s -p gfx/2d/Factory.cpp dom/canvas/ClientWebGLContext.cpp accessible/xul/XULAlertAccessible.cpp (C/C++)
./mach lint --warnings --outgoing
./mach static-analysis check dom/canvas/ClientWebGLContext.cpp (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code ?

You can file a bug blocking Bug 1415824 for untested files that should be tested.
You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Code analysis found 9 defects in the diff 2934:

1 build error found by Coverity
1 defect found by clang-tidy
1 defect found by code coverage analysis
1 defect found by license (Mozlint)
2 defects found by eslint (Mozlint)
3 defects found by clang-format

You can run this analysis locally with:

./mach clang-format -s -p gfx/2d/Factory.cpp accessible/xul/XULAlertAccessible.cpp dom/canvas/ClientWebGLContext.cpp (C/C++)
./mach lint --warnings --outgoing
./mach static-analysis check dom/canvas/ClientWebGLContext.cpp (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code ?

You can file a bug blocking Bug 1415824 for untested files that should be tested.
You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Code analysis found 9 defects in the diff 2934:

1 build error found by Coverity
1 defect found by clang-tidy
1 defect found by code coverage analysis
1 defect found by license (Mozlint)
2 defects found by eslint (Mozlint)
3 defects found by clang-format

You can run this analysis locally with:

./mach clang-format -s -p dom/canvas/ClientWebGLContext.cpp accessible/xul/XULAlertAccessible.cpp gfx/2d/Factory.cpp (C/C++)
./mach lint --warnings --outgoing
./mach static-analysis check dom/canvas/ClientWebGLContext.cpp (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code ?

You can file a bug blocking Bug 1415824 for untested files that should be tested.
You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Code analysis found 9 defects in the diff 2934:

1 build error found by Coverity
1 defect found by clang-tidy
1 defect found by code coverage analysis
1 defect found by license (Mozlint)
2 defects found by eslint (Mozlint)
3 defects found by clang-format

You can run this analysis locally with:

./mach clang-format -s -p gfx/2d/Factory.cpp dom/canvas/ClientWebGLContext.cpp accessible/xul/XULAlertAccessible.cpp (C/C++)
./mach lint --warnings --outgoing
./mach static-analysis check dom/canvas/ClientWebGLContext.cpp (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code ?

You can file a bug blocking Bug 1415824 for untested files that should be tested.
You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Code analysis found 9 defects in the diff 2934:

1 build error found by Coverity
1 defect found by clang-tidy
1 defect found by code coverage analysis
1 defect found by license (Mozlint)
2 defects found by eslint (Mozlint)
3 defects found by clang-format

You can run this analysis locally with:

./mach clang-format -s -p dom/canvas/ClientWebGLContext.cpp gfx/2d/Factory.cpp accessible/xul/XULAlertAccessible.cpp (C/C++)
./mach lint --warnings --outgoing
./mach static-analysis check dom/canvas/ClientWebGLContext.cpp (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code ?

You can file a bug blocking Bug 1415824 for untested files that should be tested.
You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Code analysis found 9 defects in the diff 2934:

1 build error found by Coverity
1 defect found by clang-tidy
1 defect found by code coverage analysis
1 defect found by license (Mozlint)
2 defects found by eslint (Mozlint)
3 defects found by clang-format

You can run this analysis locally with:

./mach clang-format -s -p accessible/xul/XULAlertAccessible.cpp gfx/2d/Factory.cpp dom/canvas/ClientWebGLContext.cpp (C/C++)
./mach lint --warnings --outgoing
./mach static-analysis check dom/canvas/ClientWebGLContext.cpp (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code ?

You can file a bug blocking Bug 1415824 for untested files that should be tested.
You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Code analysis found 9 defects in the diff 2934:

1 build error found by Coverity
1 defect found by clang-tidy
1 defect found by code coverage analysis
1 defect found by license (Mozlint)
2 defects found by eslint (Mozlint)
3 defects found by clang-format

You can run this analysis locally with:

./mach clang-format -s -p accessible/xul/XULAlertAccessible.cpp gfx/2d/Factory.cpp dom/canvas/ClientWebGLContext.cpp (C/C++)
./mach lint --warnings --outgoing
./mach static-analysis check dom/canvas/ClientWebGLContext.cpp (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code ?

You can file a bug blocking Bug 1415824 for untested files that should be tested.
You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Code analysis found 9 defects in the diff 2934:

1 build error found by Coverity
1 defect found by clang-tidy
1 defect found by code coverage analysis
1 defect found by license (Mozlint)
2 defects found by eslint (Mozlint)
3 defects found by clang-format

You can run this analysis locally with:

./mach clang-format -s -p gfx/2d/Factory.cpp dom/canvas/ClientWebGLContext.cpp accessible/xul/XULAlertAccessible.cpp (C/C++)
./mach lint --warnings --outgoing
./mach static-analysis check dom/canvas/ClientWebGLContext.cpp (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code ?

You can file a bug blocking Bug 1415824 for untested files that should be tested.
You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Code analysis found 9 defects in the diff 2934:

1 build error found by Coverity
1 defect found by clang-tidy
1 defect found by code coverage analysis
1 defect found by license (Mozlint)
2 defects found by eslint (Mozlint)
3 defects found by clang-format

You can run this analysis locally with:

./mach clang-format -s -p dom/canvas/ClientWebGLContext.cpp gfx/2d/Factory.cpp accessible/xul/XULAlertAccessible.cpp (C/C++)
./mach lint --warnings --outgoing
./mach static-analysis check dom/canvas/ClientWebGLContext.cpp (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code ?

You can file a bug blocking Bug 1415824 for untested files that should be tested.
You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Code analysis found 9 defects in the diff 2934:

1 build error found by Coverity
1 defect found by clang-tidy
1 defect found by code coverage analysis
1 defect found by license (Mozlint)
2 defects found by eslint (Mozlint)
3 defects found by clang-format

You can run this analysis locally with:

./mach clang-format -s -p dom/canvas/ClientWebGLContext.cpp gfx/2d/Factory.cpp accessible/xul/XULAlertAccessible.cpp (C/C++)
./mach lint --warnings --outgoing
./mach static-analysis check dom/canvas/ClientWebGLContext.cpp (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code ?

You can file a bug blocking Bug 1415824 for untested files that should be tested.
You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Code analysis found 9 defects in the diff 2934:

1 build error found by Coverity
1 defect found by clang-tidy
1 defect found by code coverage analysis
1 defect found by license (Mozlint)
2 defects found by eslint (Mozlint)
3 defects found by clang-format

You can run this analysis locally with:

./mach clang-format -s -p gfx/2d/Factory.cpp dom/canvas/ClientWebGLContext.cpp accessible/xul/XULAlertAccessible.cpp (C/C++)
./mach lint --warnings --outgoing
./mach static-analysis check dom/canvas/ClientWebGLContext.cpp (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code ?

You can file a bug blocking Bug 1415824 for untested files that should be tested.
You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Code analysis found 9 defects in the diff 2934:

1 build error found by Coverity
1 defect found by clang-tidy
1 defect found by code coverage analysis
1 defect found by license (Mozlint)
2 defects found by eslint (Mozlint)
3 defects found by clang-format

You can run this analysis locally with:

./mach clang-format -s -p gfx/2d/Factory.cpp accessible/xul/XULAlertAccessible.cpp dom/canvas/ClientWebGLContext.cpp (C/C++)
./mach lint --warnings --outgoing
./mach static-analysis check dom/canvas/ClientWebGLContext.cpp (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code ?

You can file a bug blocking Bug 1415824 for untested files that should be tested.
You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Code analysis found 9 defects in the diff 2934:

1 build error found by Coverity
1 defect found by clang-tidy
1 defect found by code coverage analysis
1 defect found by license (Mozlint)
2 defects found by eslint (Mozlint)
3 defects found by clang-format

You can run this analysis locally with:

./mach clang-format -s -p dom/canvas/ClientWebGLContext.cpp gfx/2d/Factory.cpp accessible/xul/XULAlertAccessible.cpp (C/C++)
./mach lint --warnings --outgoing
./mach static-analysis check dom/canvas/ClientWebGLContext.cpp (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
Should they have tests, or are they dead code ?

You can file a bug blocking Bug 1415824 for untested files that should be tested.
You can file a bug blocking Bug 1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.